Skip to content

Improved DLT tests#1010

Merged
mwojtyczka merged 6 commits into
mainfrom
test_dlt
Jan 24, 2026
Merged

Improved DLT tests#1010
mwojtyczka merged 6 commits into
mainfrom
test_dlt

Conversation

@mwojtyczka

Copy link
Copy Markdown
Contributor

Changes

Improved DLT tests by using full Unity Catalog mode.

Linked issues

Resolves #1001

Tests

  • manually tested
  • added unit tests
  • added integration tests
  • added end-to-end tests
  • added performance tests

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the e2e demo tests to run DLT in full Unity Catalog mode and to use a shared ws (workspace client) fixture instead of instantiating WorkspaceClient() inside each test.

Changes:

  • Replaced per-test WorkspaceClient() construction with a ws fixture passed into tests.
  • Updated the DLT demo test to create a schema in TEST_CATALOG and configure the pipeline with catalog/schema for full UC mode.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@grusin-db grusin-db left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread tests/e2e/test_run_demos.py
@github-actions

github-actions Bot commented Jan 23, 2026

Copy link
Copy Markdown
Contributor

✅ 520/520 passed, 18 flaky, 31 skipped, 3h50m16s total

Flaky tests:

  • 🤪 test_quality_checker_workflow_with_ref (10.013s)
  • 🤪 test_quality_checker_workflow_for_patterns (10.008s)
  • 🤪 test_quality_checker_workflow_for_patterns_exclude_patterns (10.013s)
  • 🤪 test_quality_checker_workflow_for_patterns_exclude_output (10.013s)
  • 🤪 test_quality_checker_workflow_for_patterns_table_checks_storage (10.005s)
  • 🤪 test_quality_checker_workflow_with_metrics (10.008s)
  • 🤪 test_quality_checker_workflow_with_quarantine_and_metrics (10.014s)
  • 🤪 test_e2e_workflow_with_metrics (10.013s)
  • 🤪 test_profiler_detect_pk_from_path_with_llm (1m32.924s)
  • 🤪 test_custom_metrics_in_workflow_for_all_run_configs (10.013s)
  • 🤪 test_profiler_runner_raise_error_when_profile_summary_stats_file_missing (10.013s)
  • 🤪 test_profiler_workflow_with_ai_rules_generation_and_model_api_keys_as_secrets (10.013s)
  • 🤪 test_quality_checker_workflow_with_streaming_quarantine_and_metrics (10.013s)
  • 🤪 test_col_is_not_null_and_not_empty (10.011s)
  • 🤪 test_col_is_not_null_and_is_in_list_mismatch_datatype (10.005s)
  • 🤪 test_quality_checker_workflow_with_continuous_streaming_quarantine_and_metrics (10.013s)
  • 🤪 test_col_is_not_empty (10.014s)
  • 🤪 test_e2e_workflow_serverless (10m18.6s)

Running from acceptance #3668

@codecov

codecov Bot commented Jan 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.72%. Comparing base (0bfaecc) to head (e7d76d6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1010      +/-   ##
==========================================
+ Coverage   90.60%   90.72%   +0.12%     
==========================================
  Files          64       64              
  Lines        6526     6526              
==========================================
+ Hits         5913     5921       +8     
+ Misses        613      605       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ghanse ghanse left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

catalog = TEST_CATALOG
schema = make_schema(catalog_name=catalog).name

path = Path(__file__).parent.parent.parent / "demos" / "dqx_dlt_demo.py"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add more complete DLT tests as a follow-up issue?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can add it as part of this PR, but what does it mean more complete tests? e.g. containing materialized views?

@mwojtyczka
mwojtyczka merged commit 083d946 into main Jan 24, 2026
15 checks passed
@mwojtyczka
mwojtyczka deleted the test_dlt branch January 24, 2026 09:23
mwojtyczka added a commit that referenced this pull request Feb 9, 2026
* New DQX Data Quality Dashboard ([#1019](#1019)). The data quality dashboard has been significantly enhanced to provide a centralized view of data quality metrics across all tables, allowing users to monitor and track data quality issues with greater ease. The dashboard now consists of three tabs - Data Quality Summary, Data Quality by Table (Time Series), and Data Quality by Table (Full Snapshot) - each catering to different monitoring scenarios, and offers customizable parameters for reporting column names and filtering tables with data quality issues. Additionally, the installation process for the dashboard has been simplified, with options to import it directly to a Workspace or deploy it automatically using the Databricks CLI.
* DQX App Skeleton ([#982](#982)). The DQX application (frontend and backend) has been built with a core set of features, including configuration management and AI-assisted rule generation based on natural-language input from users. A comprehensive README documents the application architecture as well as development and deployment workflows. Future versions of DQX will introduce additional functionality (loading/saving rules, rules authoring in graphical form) and provide a streamlined, user-friendly way to deploy the application directly into a Databricks workspace.
* Added Decimal support to check functions and to min_max generator ([#1013](#1013)) ([#1017](#1017)). The data quality checks have been enhanced to support Python's Decimal type, in addition to int and float, for min/max validation checks, enabling proper data quality checks for decimal-precise financial and scientific data where floating-point precision issues would cause false positives.
* Added DQX produciton best practices and fix datetime limit handling ([#997](#997)). Practical guidance and best practices for using DQX in production have been added, covering aspects such as storing checks in Delta tables, enforcing access controls, and optimizing rules for performance and scalability. Fixes have also been implemented to address issues related to handling date and datetime limits, particularly when provided as strings.
* Added new row-level check functions: is_null, is_empty, and is_null_or_empty ([#1015](#1015)). DQX now includes three new check functions, `is_null`, `is_empty`, and `is_null_or_empty`, which enable verification of column values as null, empty strings, or both, complementing existing checks like `is_not_null`, `is_not_empty`, and `is_not_null_and_not_empty`. The functions also support optional arguments, like `trim_strings` to trim spaces from strings.
* Added tolerance to equality and non-equality check functions ([#1011](#1011)). The library's quality check functionality has been enhanced to support absolute and relative tolerance parameters for numeric value comparisons in `is_equal_to`,  `is_not_equal_to`, `is_aggr_equal` and `is_aggr_not_equal` checks, allowing for more flexible and precise control over data validation. The introduction of tolerance logic, which checks for absolute and relative differences within specified thresholds via `abs_tolerance` and `rel_tolerance` parameters, provides more nuanced comparisons for numeric data.
* Allow new lines in sql expression checks ([#1009](#1009)). SQL expression check function (`sql_expression`) has been updated to support new lines in its expression argument, allowing for more complex and formatted SQL expressions.
* Allow summary metrics with SparkConnect sessions ([#1000](#1000)). The library now supports writing summary metrics directly to a table with SparkConnect sessions, eliminating the need for a classic compute cluster in Dedicated access mode. This change lifts the previous restriction and enables generatic summary metrics  using Serverless and all standard clusters with Databricks Runtime 17.3LTS or higeher.
* Fixed loading checks from a delta table with special characters ([#992](#992)). The loading checks functionality from a delta table has been fixed to handle special characters in the fully qualified table.
* Fixed resolution of pii detection check function ([#1003](#1003)). The PII detection check function resolution has been enhanced to support the application of checks defined as metadata (YAML).
* Fixed serialization/deserialization of row filter parameter for dataset-level rules ([#1021](#1021)). The `filter` field in checks definition now correctly pushes down the `filter` condition defined at the check-level as `row_filter` to the check function, allowing checks to operate on the relevant subset of rows before aggregation. The documentation has been updated to advice users to use  op-level `filter` condition for consistency instead of `row_filter` parameter. Overall, these changes aim to enhance the overall user experience.
* Improved Lakeflow Declarative Pipeline tests ([#1010](#1010)). The Lakeflow Declarative Pipeline (LDP) tests have been enhanced to utilize full Unity Catalog mode, enabling support for writing to arbitrary catalogs and schemas, and performing additional checks to prevent certain operations.
* Updated Lakebase authentication method ([#975](#975)). The Lakebase authentication method has been updated to utilize a client ID instead of a username, simplifying its use in the context of a Databricks App. The `lakebase_user` parameter has been replaced with `lakebase_client_id`, an optional service principal client ID used to connect to Lakebase, defaulting to the caller's identity if not provided. This change enhances the security and reliability of the authentication process, making it easier to work with Lakebase as a checks storage.
* Updated handling of metadata columns during schema validation ([#1002](#1002)). The `has_valid_schema` check has been enhanced to provide more flexibility in schema validation by introducing an optional `exclude_columns` parameter, allowing users to specify columns to ignore during validation. This parameter can be used to exclude metadata columns or other columns not relevant to schema validation, and it takes precedence over the `columns` list.
* Updated product info when missing in config while verifying workspace client ([#987](#987)). The workspace client configuration has been enhanced to default product information to `dqx` with the current version when it is missing, ensuring that product information is always set for telemetry purposes.
* Updated profiler and generator documentation ([#1026](#1026)). The data profiling and quality checks generation feature has been enhanced with updated documentation, providing reference information for data quality profile types and associated rules.
* Added filter attribute in rules generated from ODCS ([#978](#978)). The rules generation process has been enhanced with the introduction of a filter attribute in rules generated from Open Data Contract Standard (ODCS), allowing for more flexible and targeted rules creation.
@mwojtyczka mwojtyczka mentioned this pull request Feb 9, 2026
mwojtyczka added a commit that referenced this pull request Feb 9, 2026
Change Log for New Release:
* New DQX Data Quality Dashboard
([#1019](#1019)). The data
quality dashboard has been significantly enhanced to provide a
centralized view of data quality metrics across all tables, allowing
users to monitor and track data quality issues with greater ease. The
dashboard now consists of three tabs - Data Quality Summary, Data
Quality by Table (Time Series), and Data Quality by Table (Full
Snapshot) - each catering to different monitoring scenarios, and offers
customizable parameters for reporting column names and filtering tables
with data quality issues. Additionally, the installation process for the
dashboard has been simplified, with options to import it directly to a
Workspace or deploy it automatically using the Databricks CLI.
* DQX App Skeleton
([#982](#982)). The DQX
application (frontend and backend) has been built with a core set of
features, including configuration management and AI-assisted rule
generation based on natural-language input from users. A comprehensive
README documents the application architecture as well as development and
deployment workflows. Future versions of DQX will introduce additional
functionality (loading/saving rules, rules authoring in graphical form)
and provide a streamlined, user-friendly way to deploy the application
directly into a Databricks workspace.
* Added Decimal support to check functions and to min_max generator
([#1013](#1013))
([#1017](#1017)). The data
quality checks have been enhanced to support Python's Decimal type, in
addition to int and float, for min/max validation checks, enabling
proper data quality checks for decimal-precise financial and scientific
data where floating-point precision issues would cause false positives.
* Added DQX produciton best practices and fix datetime limit handling
([#997](#997)). Practical
guidance and best practices for using DQX in production have been added,
covering aspects such as storing checks in Delta tables, enforcing
access controls, and optimizing rules for performance and scalability.
Fixes have also been implemented to address issues related to handling
date and datetime limits, particularly when provided as strings.
* Added new row-level check functions: is_null, is_empty, and
is_null_or_empty
([#1015](#1015)). DQX now
includes three new check functions, `is_null`, `is_empty`, and
`is_null_or_empty`, which enable verification of column values as null,
empty strings, or both, complementing existing checks like
`is_not_null`, `is_not_empty`, and `is_not_null_and_not_empty`. The
functions also support optional arguments, like `trim_strings` to trim
spaces from strings.
* Added tolerance to equality and non-equality check functions
([#1011](#1011)). The
library's quality check functionality has been enhanced to support
absolute and relative tolerance parameters for numeric value comparisons
in `is_equal_to`, `is_not_equal_to`, `is_aggr_equal` and
`is_aggr_not_equal` checks, allowing for more flexible and precise
control over data validation. The introduction of tolerance logic, which
checks for absolute and relative differences within specified thresholds
via `abs_tolerance` and `rel_tolerance` parameters, provides more
nuanced comparisons for numeric data.
* Allow new lines in sql expression checks
([#1009](#1009)). SQL
expression check function (`sql_expression`) has been updated to support
new lines in its expression argument, allowing for more complex and
formatted SQL expressions.
* Allow summary metrics with SparkConnect sessions
([#1000](#1000)). The
library now supports writing summary metrics directly to a table with
SparkConnect sessions, eliminating the need for a classic compute
cluster in Dedicated access mode. This change lifts the previous
restriction and enables generatic summary metrics using Serverless and
all standard clusters with Databricks Runtime 17.3LTS or higeher.
* Fixed loading checks from a delta table with special characters
([#992](#992)). The loading
checks functionality from a delta table has been fixed to handle special
characters in the fully qualified table.
* Fixed resolution of pii detection check function
([#1003](#1003)). The PII
detection check function resolution has been enhanced to support the
application of checks defined as metadata (YAML).
* Fixed serialization/deserialization of row filter parameter for
dataset-level rules
([#1021](#1021)). The
`filter` field in checks definition now correctly pushes down the
`filter` condition defined at the check-level as `row_filter` to the
check function, allowing checks to operate on the relevant subset of
rows before aggregation. The documentation has been updated to advice
users to use op-level `filter` condition for consistency instead of
`row_filter` parameter. Overall, these changes aim to enhance the
overall user experience.
* Improved Lakeflow Declarative Pipeline tests
([#1010](#1010)). The
Lakeflow Declarative Pipeline (LDP) tests have been enhanced to utilize
full Unity Catalog mode, enabling support for writing to arbitrary
catalogs and schemas, and performing additional checks to prevent
certain operations.
* Updated Lakebase authentication method
([#975](#975)). The Lakebase
authentication method has been updated to utilize a client ID instead of
a username, simplifying its use in the context of a Databricks App. The
`lakebase_user` parameter has been replaced with `lakebase_client_id`,
an optional service principal client ID used to connect to Lakebase,
defaulting to the caller's identity if not provided. This change
enhances the security and reliability of the authentication process,
making it easier to work with Lakebase as a checks storage.
* Updated handling of metadata columns during schema validation
([#1002](#1002)). The
`has_valid_schema` check has been enhanced to provide more flexibility
in schema validation by introducing an optional `exclude_columns`
parameter, allowing users to specify columns to ignore during
validation. This parameter can be used to exclude metadata columns or
other columns not relevant to schema validation, and it takes precedence
over the `columns` list.
* Updated product info when missing in config while verifying workspace
client ([#987](#987)). The
workspace client configuration has been enhanced to default product
information to `dqx` with the current version when it is missing,
ensuring that product information is always set for telemetry purposes.
* Updated profiler and generator documentation
([#1026](#1026)). The data
profiling and quality checks generation feature has been enhanced with
updated documentation, providing reference information for data quality
profile types and associated rules.
* Added filter attribute in rules generated from ODCS
([#978](#978)). The rules
generation process has been enhanced with the introduction of a filter
attribute in rules generated from Open Data Contract Standard (ODCS),
allowing for more flexible and targeted rules creation.

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: ATTEMPT_ANALYSIS_IN_PIPELINE_QUERY_FUNCTION when using with SDP

4 participants